Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up peerdid-swift #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kukgini
Copy link
Contributor

@kukgini kukgini commented Nov 6, 2024

bump up peerdid-swift version to 3.0.3 to avoid build issue.

@conanoc
Copy link
Contributor

conanoc commented Nov 7, 2024

Can you elaborate on the build issue? Is it due to the Xcode upgrade?

@kukgini
Copy link
Contributor Author

kukgini commented Nov 8, 2024

In the peerdid-swift version 3.0.0, the dependency on coredid-swift was from 2.0.0 to the next major.

However, coredid-swift changed an attribute name of a struct exposed as public in the 2.0.2 release. Specifically, DIDDocument.verificationMethods was changed to DIDDocument.verificationMethod. I believe this was done for aligning with the W3C standard. And, the peerdid-swift 3.0.0 already changed it's name to the new one (a.k.a. verficationMethod).

As a result, in an environment where package resolve was already at 2.0.1, the build could fail due to an attribute name mismatch. I submitted a PR to address this and it was included in 3.0.3.
see: beatt83/peerdid-swift#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants