Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: did type in message crates #1179

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

GHkrishna
Copy link

Resolves #1165

Use did_parser_nom's Did type in message crates instead of string so as to parse & verify DIDs upon message deserialization

@Patrik-Stas
Copy link
Contributor

Hi @GHkrishna please have a look at my comment in your previous PR:
#1171 (comment)

Given things as they are, the code doesn't compile, the changes you made need more sync up across the codebase.

@nain-F49FF806
Copy link
Member

@GHkrishna In your local project directory, try running cargo clippy in the terminal.
This will show up some of the things that you will need to do for your fix to be correct and complete.

Once you have taken care of the clippy suggestions, your code should compile.
We can then assist you further.

Best regards.

@GHkrishna GHkrishna marked this pull request as draft April 19, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Did type in messages crate
3 participants