Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugins docs outline #1560
base: main
Are you sure you want to change the base?
Add plugins docs outline #1560
Changes from 5 commits
f3db267
f96a1c7
d60cfbc
79d0cac
5ad6ed9
a17d48d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to walk the user through creating the sequencer? This seems difficult. Or do we envision this as more of a walkthrough on how it was accomplished, and not asking much of the user? One thing we could do is also use an example from each of Linea's modified areas in the plug-in. I.e. walk through tx pool changes, block validation changes, creation limits, more, and only discuss one area. E.g. Modify x in the tx pool (step 1), modify y in block validation (Step 2). Only going through one example per area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's necessary to discuss the Linea plugin in the docs, then yes maybe the latter would be helpful. If the goal is to help users learn how to create a plugin from scratch, we could first focus on a simpler use case that would be easier to create an end-to-end tutorial for? I.e., the tutorial that would go in Get started > Create a simple plugin.