Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document sequenced transaction pool behavior #1600

Merged
merged 30 commits into from
Jun 12, 2024
Merged

Document sequenced transaction pool behavior #1600

merged 30 commits into from
Jun 12, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented May 22, 2024 •
edited
Loading

Document sequenced transaction pool behavior.

Fixes #1561

Docs preview

@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
besu-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 8:50pm

@joaniefromtheblock
Add sequenced text
addb70a 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
update language
04d8b34 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review June 5, 2024 22:25
@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner June 5, 2024 22:25
@joaniefromtheblock
Update wording
c111556 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
Updatedescription
ac84e77 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
slight reword
e48ffde 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
edit
eeeb67e 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock joaniefromtheblock self-assigned this Jun 10, 2024
@joaniefromtheblock
Update pool.md
a413641 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
Update table
6a7fe0d 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
add clearer language
9c81f60 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
add links
0d46e8b 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock @alexandratran
Update docs/public-networks/concepts/transactions/pool.md
30abd8a 
Co-authored-by: Alexandra Tran Carrillo <[email protected]>
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
add missing link
c121fd5 
Signed-off-by: Joan E <[email protected]>
alexandratran
alexandratran reviewed Jun 12, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to separate out the subscriptions from the methods table.

docs/public-networks/concepts/transactions/pool.md Outdated Show resolved Hide resolved
docs/public-networks/concepts/transactions/pool.md Outdated Show resolved Hide resolved
@joaniefromtheblock
Copy link
Contributor Author

Suggestion to separate out the subscriptions from the methods table.

Thank you. Applied you suggestions

alexandratran
alexandratran approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a formatting issue with the new table. I think it's fixed now, but can you check that it previews properly? If so, LGTM.

@joaniefromtheblock
reformat table
0d91981 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
remove space
39b51d6 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock
Update link
074754d 
Signed-off-by: Joan E <[email protected]>
@joaniefromtheblock joaniefromtheblock merged commit 858a159 into main Jun 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fab-10 fab-10 fab-10 approved these changes

@alexandratran alexandratran alexandratran approved these changes

Assignees

@joaniefromtheblock joaniefromtheblock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The sequenced transaction pool behaviour isn't documented
3 participants
@joaniefromtheblock @alexandratran @fab-10