-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1606 node clients replaces merge #1610
Conversation
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: Joan E <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some feedback. I'd suggest a technical review since there's additional content here.
Also, we generally use a 100 character line limit: https://docs-template.consensys.io/contribute/format-markdown#column-limit
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
proof Signed-off-by: m4sterbunny <[email protected]>
as per discussion with Fabio Signed-off-by: m4sterbunny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, looks fine otherwise.
responds to tech review Signed-off-by: m4sterbunny <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided some additional (minor) feedback.
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
Signed-off-by: m4sterbunny <[email protected]>
Execution-Consensus-Client-EngineAPI.png to Execution-Consensus-Clients-EngineAPI.png Signed-off-by: m4sterbunny <[email protected]>
Not merging yet -- want to verify that image update is def fine. But, that leaves open the Q: how does the consensus client get "the validated data from the execution client"? |
OK -- so going to merge -- Execution does emit messages back to Consensus, but apparently the single headed arrow show direction of API requests as standard >> whereas sequence diagram would specify the response |
Instances referring to "The Merge" linked to Ethereum docs
The Merge page >> Node clients
Small updates to affected pages