Remove --host-whitelist 2.0 #7884
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marlene Marz <[email protected]>
Signed-off-by: Marlene Marz <[email protected]>
jframe
reviewed
Nov 19, 2024
| paramLabel = "<hostname>[,<hostname>...]... or * or all", | ||
| description = | ||
| "Deprecated in favor of --host-allowlist. Comma separated list of hostnames to allow for RPC access, or * to accept any host (default: ${DEFAULT-VALUE})") | ||
| private final JsonRPCAllowlistHostsProperty hostsWhitelist = new JsonRPCAllowlistHostsProperty(); |
There was a problem hiding this comment.
There is also some code in the configure method of BesuCommand that uses the hostsWhitelist variable that needs to be removed as well
There was a problem hiding this comment.
Thanks for the review! You mean this part further down in the same file, of another one?
// hostsWhitelist is a hidden option. If it is specified, add the list to hostAllowlist
if (!hostsWhitelist.isEmpty()) {
// if allowlist == default values, remove the default values
if (hostsAllowlist.size() == 2
&& hostsAllowlist.containsAll(List.of("localhost", "127.0.0.1"))) {
hostsAllowlist.removeAll(List.of("localhost", "127.0.0.1"));
}
hostsAllowlist.addAll(hostsWhitelist);
}
There was a problem hiding this comment.
@JanetMo if you run ./gradlew compileJava you will see compile errors locally
macfarla
reviewed
Nov 27, 2024
| @@ -66,7 +66,6 @@ services: | |||
| - --rpc-ws-enabled | |||
| - --rpc-ws-apis=admin,eth,miner,web3,net,priv,eea | |||
| - --rpc-ws-host=0.0.0.0 | |||
| - --host-whitelist=* | |||
There was a problem hiding this comment.
instead of deleting this line, can you change to host-allowlist
| @@ -84,7 +83,6 @@ services: | |||
| - --rpc-ws-enabled | |||
| - --rpc-ws-apis=admin,eth,miner,web3,net,priv,eea | |||
| - --rpc-ws-host=0.0.0.0 | |||
| - --host-whitelist=* | |||
There was a problem hiding this comment.
instead of deleting this line, can you change to host-allowlist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the --host-whitelist option, issue #7761
deleted the command and it's associated tests, the changelog was already adapted