Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized my_array variable in the script Update dco_check.sh #7898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdqst
Copy link
Contributor

@mdqst mdqst commented Nov 21, 2024

PR description

This pull request addresses an issue where the my_array variable was not initialized at the beginning of the script. The variable was used for accumulating branch names, but it wasn't explicitly initialized, which could lead to potential errors or unexpected behavior when the script is executed.

Fix Summary:

  • Initialization of my_array: The array my_array has now been initialized before its usage. This ensures that the array is properly set up and avoids any issues when appending values to it.
  • Script functionality preserved: The script continues to function as expected, checking all branches for commits missing the Signed-off-by line.

Importance of the fix:

  • Prevents runtime errors: Without initializing the array, the script could behave unpredictably or throw an error when trying to append values to an uninitialized variable.
  • Ensures stability: Proper initialization of variables helps ensure that the script runs consistently across different environments without causing unexpected crashes or issues.

This change improves the reliability of the script and ensures that it will work as intended across various systems.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Fix uninitialized my_array variable in the script

Signed-off-by: Dmitry <[email protected]>
@garyschulte
Copy link
Contributor

Have you tried to get this to fail by submitting a PR from a remote repository that has no branches? What do you expect the failure scenario to look like? also, do me a favor - count the number of punctuation marks in my message. Let me know this isn't automation.

@macfarla
Copy link
Contributor

Have you tried to get this to fail by submitting a PR from a remote repository that has no branches? What do you expect the failure scenario to look like? also, do me a favor - count the number of punctuation marks in my message. Let me know this isn't automation.

agree with closing this as a spurious change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants