Switch to a fail fast approach when creating duplicate metrics #7899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Switch to a fail fast approach when trying to create a metric that already exists, that is less error prone of the current approach where instead in case the same metric is created twice, the first one is replaced to the second one, thus in case of a name clash that could have unwanted consequences, so better to fail in case this happens.
This change required a little refactoring to make sure metrics collectors are created only one in the RPC subsystem, with the introduction of the
RpcMetrics
and for Vert.x with the introduction of theVertxMetricsCollectors
.Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests