Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a fail fast approach when creating duplicate metrics #7899

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Nov 21, 2024

PR description

Switch to a fail fast approach when trying to create a metric that already exists, that is less error prone of the current approach where instead in case the same metric is created twice, the first one is replaced to the second one, thus in case of a name clash that could have unwanted consequences, so better to fail in case this happens.

This change required a little refactoring to make sure metrics collectors are created only one in the RPC subsystem, with the introduction of the RpcMetrics and for Vert.x with the introduction of the VertxMetricsCollectors.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the fail-fast-approach-for-metric-system branch 3 times, most recently from a7e30de to 719e0ef Compare November 21, 2024 16:06
@fab-10 fab-10 marked this pull request as ready for review November 21, 2024 16:08
@fab-10 fab-10 self-assigned this Nov 21, 2024
@fab-10 fab-10 force-pushed the fail-fast-approach-for-metric-system branch from 719e0ef to 1a6416c Compare November 21, 2024 16:23
@fab-10 fab-10 marked this pull request as draft November 22, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant