-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLS/mTLS options and configure the GraphQL HTTP service #7910
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good, just would like to not be adding (test) code that references ommers
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
...eum/api/src/test/java/org/hyperledger/besu/ethereum/api/graphql/GraphQLHttpsServiceTest.java
Outdated
Show resolved
Hide resolved
This pr is stale because it has been open for 30 days with no activity. |
@pullurib are you still working on this PR? |
Yes, @Gabriel-Trintinalia , I'll make review changes soon. |
…raphql/GraphQLHttpsServiceTest.java Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
@macfarla, made the suggested changes . It's ready for review |
PR Description
Summary
The changes include the addition of command-line options to enable and configure TLS and mTLS for the GraphQL HTTP service.
Changes
New Command-Line Options:
--graphql-tls-enabled
: Enable TLS for the GraphQL HTTP service.--graphql-tls-keystore-file
: Path to the TLS keystore file.--graphql-tls-keystore-password-file
: Path to the file containing the password for the TLS keystore.--graphql-mtls-enabled
: Enable mTLS for the GraphQL HTTP service.--graphql-tls-truststore-file
: Path to the TLS truststore file.--graphql-tls-truststore-password-file
: Path to the file containing the password for the TLS truststore.Validation of Option Dependencies:
Testing
Documentation
CHANGELOG.md
to reflect the addition of new TLS options.Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests