Fix unnecessary use of -a option in read command in dco_check.sh

[0xbryer]

Description:

This PR fixes a typo in the script where the read command incorrectly used the -a option.

Issue:

In the following line:

while IFS= read -r -a line; do

The -a option was used, which is meant for reading input into an array. However, this was unnecessary because each line is added to an array with my_array+=( "$line" ) after reading it. The correct approach is to simply read the line without the -a option.

Fix:

while IFS= read -r line; do

Importance:

• The -a option is not required here and could lead to confusion or unintended behavior.
• Removing the -a option simplifies the command and makes the script more efficient by avoiding the unnecessary creation of an array for each line.
• This change improves the clarity and correctness of the script.

Thanks for sending a pull request! Have you done the following?

• Checked out our contribution guidelines?
• Considered documentation and added the doc-change-required label to this PR if updates are required.
• Considered the changelog and included an update if required.
• For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

• unit tests: ./gradlew build
• acceptance tests: ./gradlew acceptanceTest
• integration tests: ./gradlew integrationTest
• reference tests: ./gradlew ethereum:referenceTests:referenceTests

[fab-10]

have you evaluated the possibility that when reading the line it could result in more than one element in the line array?
Since in this case the expression my_array+=( "$line" ) will only add the first element to the my_array, could have been the -a put on purpose to kind only select the first column?

[0xbryer]

while IFS= read -r -a line; do

The difference between while IFS= read -r line; do and while IFS= read -r -a line; do lies in how the read command processes input data. Here's why the first option is often preferable.

[garyschulte]

I am inclined to close this PR since I don't think this is a substantive change. Rather, this PR looks like several others that are an attempt to farm engagement for airdrop purposes. Please refrain from this type of activity.

If you would like to dispute this observation, tell me how many two letter words I used and what they are. Bonus points for replying in the form of a haiku

[garyschulte]

my_array+=( "$line" ) already treats the line array as a string. this change has no discernible impact

[macfarla]

I am inclined to close this PR since I don't think this is a substantive change. Rather, this PR looks like several others that are an attempt to farm engagement for airdrop purposes. Please refrain from this type of activity.

If you would like to dispute this observation, tell me how many two letter words I used and what they are. Bonus points for replying in the form of a haiku

agree with closing this as a spurious change

[0xbryer]

I am inclined to close this PR since I don't think this is a substantive change. Rather, this PR looks like several others that are an attempt to farm engagement for airdrop purposes. Please refrain from this type of activity.

If you would like to dispute this observation, tell me how many two letter words I used and what they are. Bonus points for replying in the form of a haiku

Your code - your rules. I respect you and your decision.

[garyschulte]

Your code - your rules. I respect you and your decision.

So close to a haiku though.