Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionSimulator can be a singleton #7925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fab-10
Copy link
Contributor

@fab-10 fab-10 commented Nov 26, 2024

PR description

Refactor only PR, to instantiate the TransactionSimulator only one at startup and passing it around where needed, instead of recreating it in many places, this will make future PRs to support simulating txs on pending block easier.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@fab-10 fab-10 force-pushed the create-transaction-simulator-once branch 5 times, most recently from 84697c1 to 580e145 Compare November 26, 2024 21:01
@fab-10 fab-10 marked this pull request as ready for review November 26, 2024 21:26
@fab-10 fab-10 force-pushed the create-transaction-simulator-once branch from 580e145 to 07ff952 Compare November 27, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant