Move snapsync-bft-enabled to stable options

[pullurib]

PR description

Fixed Issue(s)

#7924

[macfarla]

needs a changelog entry - this will be a breaking change

[macfarla]

you'll also want to remove
hidden = true,
so the option shows in the help

[siladu]

IMO better to avoid the breaking change and make this an alias and call out the deprecation of the X version, e.g. see

besu/besu/src/main/java/org/hyperledger/besu/cli/options/storage/DiffBasedSubStorageOptions.java

Lines 58 to 69 in 27592b5

	// TODO --Xbonsai-limit-trie-logs-enabled and --Xbonsai-trie-log-pruning-enabled are deprecated,
	// remove in a future release
	@SuppressWarnings("ExperimentalCliOptionMustBeCorrectlyDisplayed")
	@Option(
	names = {
	LIMIT_TRIE_LOGS_ENABLED,
	"--Xbonsai-limit-trie-logs-enabled", // deprecated
	"--Xbonsai-trie-log-pruning-enabled" // deprecated
	},
	fallbackValue = "true",
	description = "Limit the number of trie logs that are retained. (default: ${DEFAULT-VALUE})")
	private Boolean limitTrieLogsEnabled = DEFAULT_LIMIT_TRIE_LOGS_ENABLED;

Then can add entry to changelog under "Upcoming Breaking Changes"

[pullurib]

Thanks for the suggestions. So currently I will

• add comments in the code to indicate deprecation in future release
• Add changelog entry for upcoming breaking changes
• Update documentation to indicate this option deprecation soon and that it will be enabled by default then

[matthew1001]

Yes I think I we should remove the option, not promote it to non-experimental.

So I can see the case for making this PR a changelog entry to mark it deprecated, followed by a PR after the next release or two have gone out, which basically reverses the PR I originally added the new flag under.