Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor grammatical error Update MAINTAINERS.md #7945

Closed
wants to merge 1 commit into from

Conversation

mdqst
Copy link
Contributor

@mdqst mdqst commented Nov 27, 2024

Description:
I noticed a small grammatical issue in the "Maintainers" section of the documentation. The sentence:

"5 significant changes on code have been authored in this repos by the proposed maintainer and accepted (merged PRs)."

should be corrected to:

"5 significant changes to code have been authored in this repo by the proposed maintainer and accepted (merged PRs)."

Explanation:

  • The phrase "changes to code" is the correct usage, as it indicates changes made to the code itself.

This correction ensures better clarity and grammatical accuracy in the documentation.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
Copy link
Contributor

Hey, thanks for your interest in this project, but we aren't accepting modifications to governance files from non-maintainers. If you’d like to contribute, we encourage you to tackle a programming task instead. There is a list of good first issues, take a look!

@macfarla macfarla closed this Nov 29, 2024
@mdqst mdqst deleted the patch-4 branch November 29, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants