Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to test chaincode to exploit new microfab #363

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Nov 23, 2024

New microfab version provides an up-to-date Gradle version, which the test chaincode can be updated to exploit.

This change also updates several dependencies to current versions.

This change required hyperledger-labs/microfab#174. The version of Gradle contained in microfab v0.0.19 is too old to support current versions of the Gradle shadowJar used in this change for the bare Gradle chaincode tests.

New microfab version provides an up-to-date Gradle version, which the
test chaincode can be updated to exploit.

This change also updates several dependencies to current versions.

Signed-off-by: Mark S. Lewis <[email protected]>
Copy link

sonarcloud bot commented Nov 23, 2024

@bestbeforetoday bestbeforetoday marked this pull request as ready for review November 27, 2024 18:46
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner November 27, 2024 18:46
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) November 27, 2024 18:46
@denyeart
Copy link
Contributor

Note that my fabric-samples test against latest microfab failed - https://github.com/hyperledger/fabric-samples/actions/runs/12055602173. I haven't yet looked into the reason...

@bestbeforetoday
Copy link
Member Author

I just tried running the full-stack-asset-transfer sample manually using latest fabric-samples, Fabric v3.0.0 and microfab:0.0.20. I can bring up microfab, deploy the chaincode (as a service), start the chaincode process locally, then run the client application OK. I'm not sure what hasn't worked with the test run.

I am running the chaincode with npm run start:server-debug, as per the workshop instructions. The test looks to be running as npm run start:server-nontls. I'm not sure if that could be a difference, or perhaps just timing-related.

@bestbeforetoday
Copy link
Member Author

@denyeart fabric-samples fix in hyperledger/fabric-samples#1272.

This PR is building OK and should be ready to merge. I'll see if a similar fix to the one in fabric-samples is appropriate for this repo and, if so, deliver it in another PR.

@bestbeforetoday bestbeforetoday merged commit 0d50c5f into hyperledger:main Nov 28, 2024
9 checks passed
@denyeart
Copy link
Contributor

Thanks Mark!

@bestbeforetoday bestbeforetoday deleted the microfab branch November 28, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants