Remove double decoding of event payload

All events emitted from a subscription are processed based on a configurable "payload type" (bytes, string, JSON). However, for events coming out of the block decoder, they are always coerced to JSON upfront before even being passed to the event decoder. This makes the behavior inconsistent for subscriptions based on a particular chaincode vs. channel-wide subscriptions based on the block decoder. It seems cleaner to leave the payload as bytes in the block decoder, and to only decode it into string or JSON in the event processor. Signed-off-by: Andrew Richardson <[email protected]>
hyperledger · Mar 8, 2023 · 646d4a6 · 646d4a6
1 parent fc749c3
commit 646d4a6
Show file tree

Hide file tree

Showing 5 changed files with 380 additions and 7 deletions.
diff --git a/go.mod b/go.mod
@@ -8,6 +8,7 @@ require (
 	github.com/fsnotify/fsnotify v1.5.4 // indirect
 	github.com/globalsign/mgo v0.0.0-20181015135952-eeefdecb41b8
 	github.com/golang/protobuf v1.5.2
+	github.com/golangci/golangci-lint v1.44.2 // indirect
 	github.com/google/certificate-transparency-go v1.1.1 // indirect
 	github.com/google/uuid v1.3.0 // indirect
 	github.com/gorilla/websocket v1.4.2