ATL-7741: Fix PR comments

Signed-off-by: Bassam Riman <[email protected]>

cloud-agent/service/server/src/main/scala/org/hyperledger/identus/oid4vci/service/OIDCCredentialIssuerService.scala

@@ -164,9 +164,11 @@ case class OIDCCredentialIssuerServiceImpl(
       jwtIssuer <- credentialService
         .getJwtIssuer(issuingDID, VerificationRelationship.AssertionMethod, None)
         .provideSomeLayer(ZLayer.succeed(wac))
-
+      issuerDid <- ZIO
+        .fromEither(DID.fromString(jwtIssuer.did))
+        .mapError(error => ServiceError(error))
       jwtVC <- buildJwtVerifiableCredential(
-        jwtIssuer.did,
+        issuerDid,
         subjectDID,
         credentialIdentifier,
         credentialDefinition,
@@ -177,7 +179,7 @@ case class OIDCCredentialIssuerServiceImpl(
   }
 
   def buildJwtVerifiableCredential(
-      issuerDid: String,
+      issuerDid: DID,
       subjectDid: Option[DID],
       credentialIdentifier: Option[String],
       credentialDefinition: CredentialDefinition,
@@ -192,7 +194,7 @@ case class OIDCCredentialIssuerServiceImpl(
       `type` = Set(
         "VerifiableCredential"
       ) ++ credentialDefinition.`type`, // TODO: This information should come from Schema registry by record.schemaId
-      issuer = Left(issuerDid),
+      issuer = Left(issuerDid.toString),
       issuanceDate = Instant.now(),
       maybeExpirationDate = None, // TODO: Add expiration date
       maybeCredentialSchema = None, // TODO: Add schema from schema registry