Epic VDR phase 3 branch #1245

shotexa · 2024-07-02T14:32:08Z

Description:

Epic branch for https://input-output.atlassian.net/browse/ATL-6543

This Epic PR contains commits from other feature PRs that have been reviewed separately

Closed in favor of #1385

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

My PR follows the contribution guidelines of this project
My PR is free of third-party dependencies that don't comply with the Allowlist
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
I have checked the PR title to follow the conventional commit specification

github-actions · 2024-07-02T14:45:03Z

Integration Test Results

20 files ±0 20 suites ±0 2s ⏱️ ±0s
45 tests ±0 45 ✅ ±0 0 💤 ±0 0 ❌ ±0
71 runs ±0 71 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit b59ce50. ± Comparison against base commit 693dcc4.

♻️ This comment has been updated with latest results.

github-actions · 2024-07-02T14:50:05Z

Unit Test Results

102 files +1 102 suites +1 16m 13s ⏱️ - 4m 27s
872 tests +3 864 ✅ +3 8 💤 ±0 0 ❌ ±0
879 runs +3 871 ✅ +3 8 💤 ±0 0 ❌ ±0

Results for commit b59ce50. ± Comparison against base commit 693dcc4.

♻️ This comment has been updated with latest results.

Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Shota Jolbordi <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: FabioPinheiro <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

…ci] (#1257) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

#1264) Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

# [1.38.0](cloud-agent-v1.37.0...cloud-agent-v1.38.0) (2024-07-15) ### Bug Fixes * Move InMemory classes to the test moduels ([#1240](#1240)) ([823057a](823057a)) * move mocks into the test modules ([#1236](#1236)) ([df83026](df83026)) * use Put and Get for DID in doobie statement ([#1250](#1250)) ([fc1cf51](fc1cf51)) * Wallet Management Error Handling ([#1248](#1248)) ([cfd5101](cfd5101)) ### Features * upgrade docusaurus and semantic-release packages ([de53f1d](de53f1d)) Signed-off-by: Allain Magyar <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: FabioPinheiro <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: patlo-iog <[email protected]> Signed-off-by: Hyperledger Bot <[email protected]> Co-authored-by: Yurii Shynbuiev - IOHK <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyperledger Bot <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Shota Jolbordi <[email protected]>

… envelope (#1283) Signed-off-by: Shota Jolbordi <[email protected]>

Signed-off-by: Shota Jolbordi <[email protected]>

coveralls · 2024-09-12T12:15:06Z

coverage: 48.548% (+0.02%) from 48.532%
when pulling b59ce50 on ATL-6543-epic-vdr-phase-3
into 693dcc4 on main.

Signed-off-by: Shota Jolbordi <[email protected]>

yshyn-iohk · 2024-09-27T07:40:35Z

...dger/identus/pollux/credentialdefinition/controller/CredentialDefinitionControllerImpl.scala

+    val res = for {
+      cd <- service.getByGUID(guid, ResourceResolutionMethod.did)
+      response <- ZIO
+        .fromEither(CredentialDefinitionDidUrlResponse.asPrismEnvelopeResponse(cd, baseUrlServiceName))
+        .mapError(couldNotParseCredDefResponse)
+
+    } yield response
+
+    res
+  }


Would it be better to use a for-comprehension without val res in the beginning and res in the end?

its a stylistic choise, I like this because its easier to debug later, and see the response type by hovering over.

yshyn-iohk · 2024-09-27T07:41:30Z

...dger/identus/pollux/credentialdefinition/controller/CredentialDefinitionControllerImpl.scala

-          .withBaseUri(rc.request.uri)
-      )
+  ): IO[ErrorResponse, PrismEnvelopeResponse] = {
+    val res = for {


same here. What is the purpose of this code style?

yshyn-iohk · 2024-09-27T07:49:25Z

...src/main/scala/org/hyperledger/identus/pollux/core/service/uriResolvers/DidUrlResolver.scala

+        .mapError(_ => MissingRequiredParams(uri))
+      (resourceService, resourcePath) = serviceAndPath
+      didStr = parsed.removeQueryString().toString
+      didDocument <- didResolver.resolve(didStr).flatMap {


I'm not sure this way of error detail complies with the current error-handling strategy.
Let's commit to it as it is, but discuss it with @bvoiturier at the AoH meeting.

yshyn-iohk · 2024-09-27T07:52:50Z

...src/main/scala/org/hyperledger/identus/pollux/core/service/uriResolvers/DidUrlResolver.scala

+class DidUrlResolver(httpUrlResolver: HttpUrlResolver, didResolver: DidResolver) extends UriResolver {
+  import DidUrlResolver.*
+
+  def resolve(uri: String): IO[GenericUriResolverError, String] = {


I would also try to refactor the long function and split it into the stages/phases:

parse Uri => get DID

resolve DID

fetch Services

compose the resource Url

get the resource by Url

check resource integrity (if needed)

yshyn-iohk · 2024-09-27T07:54:29Z

...rc/main/scala/org/hyperledger/identus/pollux/core/service/uriResolvers/HttpUrlResolver.scala

+          ZIO.fail(UnexpectedUpstreamResponseReceived(status.code))
+      }
+    } yield body
+    program.provideSomeLayer(zio.Scope.default)


What is the purpose of the Scope.default here?

I'm not sure It is a refactored code, but if I recall, ZIO HTTP client needs this layer to function

yshyn-iohk · 2024-09-27T07:56:00Z

...ala/org/hyperledger/identus/pollux/core/service/verification/VcVerificationServiceImpl.scala

 import org.hyperledger.identus.pollux.vc.jwt.{CredentialPayload, DidResolver, JWT, JWTVerification, JwtCredential}
-import org.hyperledger.identus.pollux.vc.jwt.CredentialPayload.Implicits
+import org.hyperledger.identus.shared.http.UriResolver
+// import org.hyperledger.identus.pollux.vc.jwt.CredentialPayload.Implicits //TODO: might not be necessary


you can always run optimize imports from the Intellij Idea

Signed-off-by: Shota Jolbordi <[email protected]>

shotexa · 2024-09-27T09:58:54Z

Closing this one due to DCO issues, see #1385

shotexa marked this pull request as draft July 2, 2024 14:32

github-actions bot added pollux docs shared cloud-agent labels Jul 16, 2024

shotexa self-assigned this Jul 16, 2024

Shota Jolbordi and others added 15 commits July 17, 2024 04:21

Empty comit to epic branch

f1565ac

Signed-off-by: Shota Jolbordi <[email protected]>

fix: Move InMemory classes to the test moduels (#1240)

e6693c6

Signed-off-by: FabioPinheiro <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

feat: upgrade docusaurus and semantic-release packages

bbc9629

Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

fix: Wallet Management Error Handling (#1248)

a80ffab

Signed-off-by: Bassam Riman <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

fix: use Put and Get for DID in doobie statement (#1250)

438e1a6

Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

chore: update codeowners files [skip ci] (#1255)

599becb

Signed-off-by: Yurii Shynbuiev - IOHK <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

chore: update CODEOWNERS to have identus-maintainers team only [skip-…

58e3302

…ci] (#1257) Signed-off-by: Yurii Shynbuiev <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

build: make sure -Dquill.macro.log=false is passed when quill compiles (

46508fa

#1264) Signed-off-by: Pat Losoponkul <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

fix: add reportProcessingFailure back in PresentationRepository (#1232)

f07809d

Signed-off-by: FabioPinheiro <[email protected]> Signed-off-by: Shota Jolbordi <[email protected]>

shotexa force-pushed the ATL-6543-epic-vdr-phase-3 branch from e6048eb to ff2d9b6 Compare July 17, 2024 00:22

github-actions bot added build infra ci mercury connect labels Jul 17, 2024

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

2ca47d6

Signed-off-by: Shota Jolbordi <[email protected]>

shotexa added 7 commits July 20, 2024 03:38

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

b138825

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

34626d0

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

0a7579e

feat(pollux): update storage for static resources to be wrapped in an…

f78596f

… envelope (#1283) Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

cda60eb

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

cf595c8

Signed-off-by: Shota Jolbordi <[email protected]>

Format

c9ef4f3

Signed-off-by: Shota Jolbordi <[email protected]>

Shota Jolbordi added 3 commits September 14, 2024 10:27

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

2fb5020

Signed-off-by: Shota Jolbordi <[email protected]>

feat: add base url services to DID (#1358)

ecde01d

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

8f2d9a9

Signed-off-by: Shota Jolbordi <[email protected]>

shotexa changed the title ~~[WIP] Epic VDR phase 3 branch~~ Epic VDR phase 3 branch Sep 19, 2024

shotexa marked this pull request as ready for review September 19, 2024 19:22

shotexa requested a review from a team as a code owner September 19, 2024 19:22

Shota Jolbordi and others added 4 commits September 20, 2024 00:15

format

2a0b369

Signed-off-by: Shota Jolbordi <[email protected]>

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

63c8160

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

5c984ee

fix: OAS and http clients for Kotliln and TypeScript (#1375)

d69e35e

yshyn-iohk reviewed Sep 27, 2024

View reviewed changes

yshyn-iohk approved these changes Sep 27, 2024

View reviewed changes

Merge branch 'main' into ATL-6543-epic-vdr-phase-3

b59ce50

Signed-off-by: Shota Jolbordi <[email protected]>

shotexa mentioned this pull request Sep 27, 2024

feat: Implement prism anoncreds method for schemas and credential definitions #1385

Merged

6 tasks

shotexa closed this Sep 27, 2024

shotexa deleted the ATL-6543-epic-vdr-phase-3 branch September 27, 2024 09:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Epic VDR phase 3 branch #1245

Epic VDR phase 3 branch #1245

shotexa commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

coveralls commented Sep 12, 2024 •

edited

Loading

yshyn-iohk Sep 27, 2024

shotexa Sep 27, 2024

yshyn-iohk Sep 27, 2024

yshyn-iohk Sep 27, 2024

yshyn-iohk Sep 27, 2024

yshyn-iohk Sep 27, 2024

shotexa Sep 27, 2024

yshyn-iohk Sep 27, 2024

shotexa commented Sep 27, 2024

Epic VDR phase 3 branch #1245

Epic VDR phase 3 branch #1245

Conversation

shotexa commented Jul 2, 2024 • edited Loading

Description:

Alternatives Considered (optional):

Checklist:

github-actions bot commented Jul 2, 2024 • edited Loading

Integration Test Results

github-actions bot commented Jul 2, 2024 • edited Loading

Unit Test Results

coveralls commented Sep 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shotexa commented Sep 27, 2024

shotexa commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

github-actions bot commented Jul 2, 2024 •

edited

Loading

coveralls commented Sep 12, 2024 •

edited

Loading