Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add KID to the credential-offers API - ATL-7704 #1320

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

FabioPinheiro
Copy link
Contributor

Description:

feat: Add KID to the credential-offers API - ATL-7704

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Unit Test Results

100 files  ±0  100 suites  ±0   15m 41s ⏱️ -9s
860 tests ±0  852 ✅ ±0  8 💤 ±0  0 ❌ ±0 
867 runs  ±0  859 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit ec12fb5. ± Comparison against base commit 6567950.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
71 runs  ±0  71 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ec12fb5. ± Comparison against base commit 6567950.

♻️ This comment has been updated with latest results.

@FabioPinheiro
Copy link
Contributor Author

For the tests to be passing ATM means there is a lack of tests

@github-actions github-actions bot added the castor label Sep 6, 2024
@FabioPinheiro FabioPinheiro changed the title [WIP] feat: Add KID to the credential-offers API - ATL-7704 feat: Add KID to the credential-offers API - ATL-7704 Sep 11, 2024
@FabioPinheiro FabioPinheiro force-pushed the feat/ATL-7704-add-KID-to-the-credential_offers-API branch from 26b91f3 to c4aa6c9 Compare September 11, 2024 16:34
@FabioPinheiro
Copy link
Contributor Author

I messed up the rebase I'm still trying to fix it

@coveralls
Copy link

coveralls commented Sep 12, 2024

Coverage Status

Changes unknown
when pulling ec12fb5 on feat/ATL-7704-add-KID-to-the-credential_offers-API
into ** on main**.

@FabioPinheiro FabioPinheiro force-pushed the feat/ATL-7704-add-KID-to-the-credential_offers-API branch from 4b4eae9 to 53c2e57 Compare September 12, 2024 10:57
@yshyn-iohk yshyn-iohk added the autoupdate Merge the main branch into a feature branch label Sep 18, 2024
@yshyn-iohk yshyn-iohk enabled auto-merge (squash) September 18, 2024 05:45
@patlo-iog
Copy link
Contributor

🚀 Merge success

@yshyn-iohk yshyn-iohk merged commit 56200cf into main Sep 18, 2024
13 checks passed
@yshyn-iohk yshyn-iohk deleted the feat/ATL-7704-add-KID-to-the-credential_offers-API branch September 18, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoupdate Merge the main branch into a feature branch castor cloud-agent pollux shared
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants