feat: presentation_submission validation logic #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pat Losoponkul <[email protected]> chore: only use claim format value defined in contract Signed-off-by: Pat Losoponkul <[email protected]> fix: adapt verification interface Signed-off-by: Pat Losoponkul <[email protected]> wip Signed-off-by: Pat Losoponkul <[email protected]> feat: ps submission entry processing Signed-off-by: Pat Losoponkul <[email protected]> test: sanity check Signed-off-by: Pat Losoponkul <[email protected]> wip: verify input constraint test: matching descriptor and submission Signed-off-by: Pat Losoponkul <[email protected]> test: basic matching descriptor Signed-off-by: Pat Losoponkul <[email protected]> test: submission id not match Signed-off-by: Pat Losoponkul <[email protected]> test: pd unique id test Signed-off-by: Pat Losoponkul <[email protected]> test: moar test!! style: fix and fmt Signed-off-by: Pat Losoponkul <[email protected]> wip test: cleanup testing tests: nested_path test and multiple descriptors Signed-off-by: Pat Losoponkul <[email protected]> test: optional field constraints test Signed-off-by: Pat Losoponkul <[email protected]>
patlo-iog
force-pushed
the
feat/prex-ps-1
branch
from
4e0323a
to
520edf8
Compare
added 2 commits
September 10, 2024 15:21
Signed-off-by: Pat Losoponkul <[email protected]>
Signed-off-by: Pat Losoponkul <[email protected]>
patlo-iog
force-pushed
the
feat/prex-ps-1
branch
3 times, most recently
from
e1861a3
to
0b9193a
Compare
Signed-off-by: Pat Losoponkul <[email protected]>
patlo-iog
force-pushed
the
feat/prex-ps-1
branch
from
0b9193a
to
cfe0144
Compare
added 2 commits
September 11, 2024 11:51
Signed-off-by: Pat Losoponkul <[email protected]>
patlo-iog
force-pushed
the
feat/prex-ps-1
branch
from
37c022a
to
32de11a
Compare
patlo-iog
changed the title
yshyn-iohk
reviewed
Sep 11, 2024
pollux/prex/src/main/scala/org/hyperledger/identus/pollux/prex/PresentationSubmission.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ATL-7645
PresentationSubmissionmodelPresentationSubmissionVerificationand tetsThe PR looks big, but half of the LOC are just test 😄