Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VCVerification API support ARRAY or OBJECT as Credential Sc… #1355

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG requested a review from a team as a code owner September 13, 2024 14:27
Copy link
Contributor

github-actions bot commented Sep 13, 2024

Unit Test Results

100 files  ±0  100 suites  ±0   18m 26s ⏱️ -30s
860 tests +1  852 ✅ +1  8 💤 ±0  0 ❌ ±0 
867 runs  +1  859 ✅ +1  8 💤 ±0  0 ❌ ±0 

Results for commit 0729ed7. ± Comparison against base commit 6a0a3ea.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 13, 2024

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
71 runs  ±0  71 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0729ed7. ± Comparison against base commit 6a0a3ea.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 13, 2024

Coverage Status

coverage: 49.009% (+0.08%) from 48.925%
when pulling 0729ed7 on ATL-7765
into 6a0a3ea on main.

Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the VcVerificationService handles multiple schemas. The test doesn't check if both schemas were validated. I might be reading it incorrectly.

@CryptoKnightIOG
Copy link
Contributor Author

CryptoKnightIOG commented Sep 13, 2024

the VcVerificationService handles multiple schemas. The test doesn't check if both schemas were validated. I might be reading it incorrectly.

@mattklepp the test parses both Schemas, validates them, then validates the JWT Credentials against both schemas. If either validations fail the test will fails. I know this for a fact because I set "additionalProperties": true in the Schemas them self since both schema check for different properties and was failing otherwise.

@CryptoKnightIOG CryptoKnightIOG merged commit 91cb4e7 into main Sep 16, 2024
14 checks passed
@CryptoKnightIOG CryptoKnightIOG deleted the ATL-7765 branch September 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants