Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot reuse the same credential-offer in oid4vci #1361

Merged
merged 2 commits into from
Sep 16, 2024
Merged

fix: cannot reuse the same credential-offer in oid4vci #1361

merged 2 commits into from
Sep 16, 2024

Conversation

patlo-iog
Copy link
Contributor

fix: cannot reuse the same credential-offer in oid4vci
2a8cf5b 
Signed-off-by: Pat Losoponkul <[email protected]>

wip

Signed-off-by: Pat Losoponkul <[email protected]>
@patlo-iog patlo-iog marked this pull request as ready for review September 16, 2024 09:14
@patlo-iog patlo-iog requested a review from a team as a code owner September 16, 2024 09:14
@patlo-iog patlo-iog added the autoupdate Merge the main branch into a feature branch label Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Unit Test Results

100 files  ±0  100 suites  ±0   15m 3s ⏱️ +3s
859 tests ±0  851 ✅ ±0  8 💤 ±0  0 ❌ ±0 
866 runs  ±0  858 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 0b64421. ± Comparison against base commit cc10ba2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
71 runs  ±0  71 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b64421. ± Comparison against base commit cc10ba2.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 16, 2024 •
edited
Loading

Coverage Status

coverage: 48.925% (+0.06%) from 48.864%
when pulling 0b64421 on fix/oid4vci-reuse-offer
into cc10ba2 on main.

@patlo-iog patlo-iog enabled auto-merge (squash) September 16, 2024 09:28
@patlo-iog
Copy link
Contributor Author

🚀 Merge success

@yshyn-iohk
Copy link
Member

@patlo-iog, should we use the nonce service to detect if the issuance session has already been used to issue the VC?

@patlo-iog
Copy link
Contributor Author

@patlo-iog, should we use the nonce service to detect if the issuance session has already been used to issue the VC?

No doubt we need to cleanup lots of oid4vci stuff. Let's tackle them when there's no pressure 😄

@patlo-iog patlo-iog merged commit 6a0a3ea into main Sep 16, 2024
13 checks passed
@patlo-iog patlo-iog deleted the fix/oid4vci-reuse-offer branch September 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

Assignees
No one assigned
Labels
autoupdate Merge the main branch into a feature branch cloud-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patlo-iog @coveralls @yshyn-iohk