Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add presentation-definition crud test #1367

Merged
merged 5 commits into from
Sep 19, 2024
Merged

test: add presentation-definition crud test #1367

merged 5 commits into from
Sep 19, 2024

Conversation

patlo-iog
Copy link
Contributor

@patlo-iog patlo-iog commented Sep 19, 2024 •
edited
Loading

ATL-7643

Pat Losoponkul added 2 commits September 19, 2024 16:40
test: dal pe test
3d6ebe5 
Signed-off-by: Pat Losoponkul <[email protected]>
chore: fix and fmt
43b6b3a 
Signed-off-by: Pat Losoponkul <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Integration Test Results

20 files  ±0  20 suites  ±0   2s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
71 runs  ±0  71 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9402ada. ± Comparison against base commit 03ce63a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Unit Test Results

101 files  +1  101 suites  +1   17m 31s ⏱️ +27s
869 tests +9  861 ✅ +9  8 💤 ±0  0 ❌ ±0 
876 runs  +9  868 ✅ +9  8 💤 ±0  0 ❌ ±0 

Results for commit 9402ada. ± Comparison against base commit 03ce63a.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 19, 2024 •
edited
Loading

Coverage Status

coverage: 48.586% (+0.3%) from 48.273%
when pulling 9402ada on pd-tests
into 03ce63a on main.

@patlo-iog patlo-iog marked this pull request as ready for review September 19, 2024 10:11
@patlo-iog patlo-iog requested a review from a team as a code owner September 19, 2024 10:11
@patlo-iog patlo-iog enabled auto-merge (squash) September 19, 2024 10:27
@patlo-iog patlo-iog added the autoupdate Merge the main branch into a feature branch label Sep 19, 2024
@patlo-iog
Copy link
Contributor Author

🚀 Merge success!

@patlo-iog
Copy link
Contributor Author

🚀 Merge success

@patlo-iog
Copy link
Contributor Author

🚀 Merge success

mattklepp
mattklepp approved these changes Sep 19, 2024
View reviewed changes
Copy link

@mattklepp mattklepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well written. Easy to understand test cases.

@patlo-iog patlo-iog merged commit 803be11 into main Sep 19, 2024
14 checks passed
@patlo-iog patlo-iog deleted the pd-tests branch September 19, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattklepp mattklepp mattklepp approved these changes

Assignees
No one assigned
Labels
autoupdate Merge the main branch into a feature branch build pollux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patlo-iog @coveralls @mattklepp