Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add serdeser for anoncred presentation request #768

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG commented Oct 25, 2023

Overview

Fixes https://input-output.atlassian.net/browse/ATL-5966

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Atala PRISM Test Results

  80 files  +1    80 suites  +1   13m 23s ⏱️ - 2m 6s
681 tests +2  670 ✔️ +2  11 💤 ±0  0 ±0 
687 runs  +2  676 ✔️ +2  11 💤 ±0  0 ±0 

Results for commit c1bae9f. ± Comparison against base commit 5318657.

This pull request removes 2 and adds 4 tests. Note that renamed tests count towards both.
io.iohk.atala.pollux.core.service.helper.PublicCredentialDefinitionSerDesSpec ‑ PublicCredentialDefinitionSerDes - should deserialise
io.iohk.atala.pollux.core.service.helper.PublicCredentialDefinitionSerDesSpec ‑ PublicCredentialDefinitionSerDes - should validate a correct schema
io.iohk.atala.pollux.core.service.serdes.AnoncredPresentationRequestSchemaSerDesSpec ‑ AnoncredPresentationRequestSerDes - should deserialize correctly
io.iohk.atala.pollux.core.service.serdes.AnoncredPresentationRequestSchemaSerDesSpec ‑ AnoncredPresentationRequestSerDes - should validate a correct schema
io.iohk.atala.pollux.core.service.serdes.PublicCredentialDefinitionSchemaSerDesSpec ‑ PublicCredentialDefinitionSerDes - should deserialise
io.iohk.atala.pollux.core.service.serdes.PublicCredentialDefinitionSchemaSerDesSpec ‑ PublicCredentialDefinitionSerDes - should validate a correct schema

♻️ This comment has been updated with latest results.

@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-5966-Create-Presentation-Proof-Request-2 branch from eb9b8a2 to 413ce93 Compare October 25, 2023 16:38
@antonbaliasnikov antonbaliasnikov changed the title feat: Added Serdeser For Anoncred Presentation Request feat: add serdeser for anoncred presentation request Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Integration Test Results

11 files  ±0  11 suites  ±0   3s ⏱️ ±0s
24 tests ±0  24 ✔️ ±0  0 💤 ±0  0 ±0 
25 runs  ±0  25 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c1bae9f. ± Comparison against base commit 5318657.

♻️ This comment has been updated with latest results.

@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-5966-Create-Presentation-Proof-Request-2 branch 4 times, most recently from b4639fc to 8ee5b52 Compare October 25, 2023 19:16
Copy link
Contributor

@bvoiturier bvoiturier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍. I would propose to merge this in a ZKP verification feature branch that we eventually merge into main when Epic implementation is complete.

@CryptoKnightIOG CryptoKnightIOG force-pushed the ATL-5966-Create-Presentation-Proof-Request-2 branch from 8ee5b52 to c1bae9f Compare October 31, 2023 00:28
@CryptoKnightIOG CryptoKnightIOG changed the base branch from main to feat/ZKP-verification October 31, 2023 00:32
@CryptoKnightIOG CryptoKnightIOG merged commit 43ae737 into feat/ZKP-verification Oct 31, 2023
11 checks passed
@CryptoKnightIOG CryptoKnightIOG deleted the ATL-5966-Create-Presentation-Proof-Request-2 branch October 31, 2023 00:41
CryptoKnightIOG added a commit that referenced this pull request Nov 15, 2023
CryptoKnightIOG added a commit that referenced this pull request Nov 18, 2023
CryptoKnightIOG added a commit that referenced this pull request Nov 20, 2023
CryptoKnightIOG added a commit that referenced this pull request Nov 22, 2023
CryptoKnightIOG added a commit that referenced this pull request Nov 30, 2023
CryptoKnightIOG added a commit that referenced this pull request Dec 19, 2023
CryptoKnightIOG added a commit that referenced this pull request Dec 20, 2023
CryptoKnightIOG added a commit that referenced this pull request Jan 3, 2024
CryptoKnightIOG added a commit that referenced this pull request Jan 24, 2024
CryptoKnightIOG added a commit that referenced this pull request Feb 3, 2024
CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024
CryptoKnightIOG added a commit that referenced this pull request Feb 9, 2024
CryptoKnightIOG added a commit that referenced this pull request Feb 18, 2024
CryptoKnightIOG added a commit that referenced this pull request Feb 23, 2024
CryptoKnightIOG added a commit that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants