[fix] #201: Add tests for transaction queries

Signed-off-by: Sam H. Smith <[email protected]>

src/client.rs

@@ -395,7 +395,7 @@ impl Client {
         Ok(items)
     }
 
-    fn query_all_transaction_by_hash(
+    fn query_transaction_by_hash(
         &self,
         tx_hash: [u8; Hash::LENGTH],
     ) -> PyResult<PyTransactionQueryOutput> {

tests/conftest.py

@@ -107,3 +107,13 @@ def GIVEN_registered_account_with_minted_assets(
                 5,
                 asset)]))
     return GIVEN_registered_account
+
+
+@pytest.fixture()
+def GIVEN_hash_of_registered_transaction(GIVEN_new_domain_id):
+    """Fixture to provide a registered transaction in Iroha"""
+    with allure.step(f'GIVEN registered domain name "{GIVEN_new_domain_id}"'):
+        tx_hash_string = client.submit_executable_only_success(
+            [iroha.Instruction
+             .register_domain(GIVEN_new_domain_id)])
+        return tx_hash_string

tests/query/transactions/conftest.py

@@ -0,0 +1,8 @@
+import allure  # type: ignore
+import pytest
+
+@pytest.fixture(scope="function", autouse=True)
+def asset_test_setup():
+    allure.dynamic.feature("Transactions")
+    allure.dynamic.story("Account queries transactions")
+    allure.dynamic.label("permission", "no_permission_required")

tests/query/transactions/test_query_transactions.py

@@ -0,0 +1,31 @@
+import allure
+import iroha
+
+from tests import client,account_id
+from tests.helpers import generate_public_key
+
+
+@allure.label("sdk_test_id", "query_all_transactions")
+def test_query_all_transactions(GIVEN_hash_of_registered_transaction):
+    with allure.step('WHEN client queries all transactions'):
+        all_txs = client.query_all_transactions()
+    with allure.step('THEN there should be some transactions present'):
+        assert len(all_txs) > 0, "No transactions found in the system"
+
+
+@allure.label("sdk_test_id", "query_all_transactions_by_account")
+def test_query_all_transactions_by_account(
+        GIVEN_hash_of_registered_transaction):
+    with allure.step('WHEN client queries all transactions by their own account'):
+        all_txs = client.query_all_transactions_by_account(account_id)
+    with allure.step('THEN there should be some transactions present'):
+        assert len(all_txs) > 0, "No transactions found in the system"
+
+@allure.label("sdk_test_id", "test_query_transaction_by_hash")
+def test_query_transaction_by_hash(
+        GIVEN_hash_of_registered_transaction):
+    with allure.step(
+            f'WHEN client queries for transaction by hash {GIVEN_hash_of_registered_transaction}"'):
+        tx = client.query_transaction_by_hash(bytes.fromhex(GIVEN_hash_of_registered_transaction))
+    with allure.step('THEN there should be a transaction present'):
+        assert tx is not None, "No transactions found in the system"