Deduplicate mem mgr and host functinos from HyperlightVm to remove category of possible errors #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ludvig Liljenberg <[email protected]>
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
added
kind/enhancement
ludfjig
changed the title
Remove MemoryManager and FunctionRegistry fields from HyperlightVm, passing them as parameters to run() and dispatch_call_from_host() instead. This eliminates duplicate ownership, simplifies the ownership model and gets rid of a complete category of possible errors. Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
dedupe_mem_mgr
branch
from
471c325 to
9dcc7b5
Compare
ludfjig
commented
Nov 6, 2025
| } | ||
| } | ||
|
|
||
| // if !self.mem_mgr.check_stack_guard()? { |
Contributor
Author
There was a problem hiding this comment.
todo: uncomment this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove MemoryManager and FunctionRegistry fields from HyperlightVm, passing them as parameters to run() and dispatch_call_from_host() instead. This eliminates duplicate ownership, simplifies the ownership model and gets rid of a complete category of possible errors, since they already live on the sandbox itself.
This is PR 1/n towards dealing with #998. Requires #924 before merging, will mark PR ready then