Use native types when calling host functions #494
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Prendes <[email protected]>
jprendes
added
kind/enhancement
jprendes
force-pushed
the
call_fn
branch
2 times, most recently
from
478e443 to
b1bf92e
Compare
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on #491.
I will mark this as ready to review once #491 is merged.
This PR changes the signature of
MultiUseSandbox::call_guest_function_by_nameandMultiUseGuestCallContext::callto use native Rust types instead of usingParamerValueandReturnValue.For a diff without the noise of the dependency PR see jprendes/hyperlight@jprendes:hyperlight:host_function_4...call_fn