Skip to content

[WIP] Remove OutBHandlerWrapper type #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

Copilot
Copy link

@Copilot Copilot AI commented May 21, 2025

  • Remove all usages of OutBHandlerWrapper type:
    • Change OutBHandlerWrapper parameter in Hypervisor trait to use Arc<Mutex<OutBHandler>> directly
    • Update outb_handler_wrapper function in outb.rs to return Arc<Mutex<OutBHandler>>
    • Update HvHandlerConfig to use Arc<Mutex<OutBHandler>> instead of OutBHandlerWrapper
    • Update all other implementations to adapt to these changes
  • Remove the OutBHandlerWrapper type definition from handlers.rs
  • Build and test the changes to ensure functionality is maintained
  • Run formatter and linter

Fixes #495.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@simongdavies simongdavies added the kind/refactor For PRs that restructure or remove code without adding new functionality. label May 21, 2025
@simongdavies
Copy link
Contributor

@copilot gpg-sign and sign-off all commits

Copy link
Author

Copilot AI commented May 21, 2025

@copilot gpg-sign and sign-off all commits

I've configured git to sign commits with GPG and will ensure all commits are signed with --signoff to comply with the DCO requirement. This is set up now with commit.gpgsign=true configured locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor For PRs that restructure or remove code without adding new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove OutBHandlerWrapper type
2 participants