Skip to content

Conversation

dblnz
Copy link
Contributor

@dblnz dblnz commented Oct 7, 2025

Fixes #747 and is a blocker for hyperlight-dev/hyperlight-wasm#129.

This modifies the guest debugging by adding a DebugMemoryAccess type that handles the memory access for the debugger. It abstracts over the type of memory, shared or mmaped.

Additionally, we now include the mmapped memory regions in the crashdump.

@dblnz dblnz added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Oct 7, 2025
@dblnz dblnz force-pushed the fix-dbg-mapped-memory branch from d463cbc to c6e40e2 Compare October 8, 2025 08:49
@dblnz dblnz marked this pull request as ready for review October 8, 2025 12:23
@dblnz dblnz added this to the v0.11.0 milestone Oct 8, 2025
@ludfjig
Copy link
Contributor

ludfjig commented Oct 10, 2025

This looks good to me, but it looks like we're circumventing our SharedMemory abstraction here with unsafe code like from_raw. Would it be possible to avoid this?

@dblnz
Copy link
Contributor Author

dblnz commented Oct 10, 2025

That is true, but I think this is a consequence of how the mmapped memory is handled. As a separate set of regions.
What I think I could do is implement something similar to SharedMemory abstraction over the mmapped memory that keeps track of accessing and mapping/unmapping.

@ludfjig
Copy link
Contributor

ludfjig commented Oct 10, 2025

That is true, but I think this is a consequence of how the mmapped memory is handled. As a separate set of regions.
What I think I could do is implement something similar to SharedMemory abstraction over the mmapped memory that keeps track of accessing and mapping/unmapping.

Oh yeah forgot about that... That might be unfeasible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate make crashdump feature work with mmaped regions

2 participants