-
Notifications
You must be signed in to change notification settings - Fork 1
chore: remove deprecated api #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewmcneely
wants to merge
20
commits into
main
Choose a base branch
from
matthewmcneely/remove-deprecated-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated generics-based API surfaces and adds a way to configure the embedded database’s in-memory cache size.
- Remove all generics-based CRUD functions (
Create
,Get
,Upsert
,Query
,Delete
) and their internal helpers underapi/
- Introduce a
cacheSizeMB
field inConfig
andClient
, aWithCacheSizeMB
setter, and propagate it intoposting.Init
- Update tests (package renames, CI invocation) and bump various dependencies in
go.mod
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
zero.go | Dropped deprecated nextUID method |
config.go | Added cacheSizeMB , default and WithCacheSizeMB , validation |
engine.go | Propagate cacheSizeMB into posting.Init |
client.go | Added cacheSizeMB to client options and key, WithCacheSizeMB |
live.go | Renamed log keys for data load progress |
load_test/live_test.go | Set cache size explicitly in live loader test |
namespace_test.go | Renamed test and switched package to modusgraph_test |
vector_test.go, engine_test.go | Switched test packages to modusgraph_test |
unit_test/… | Removed all tests for the old generics API |
api/… | Removed entire api/ folder (deprecated generics API) |
go.mod | Bumped versions of dgo, dgraph, and many indirect deps |
.github/workflows/ci-go-unit-tests.yaml | Adjusted test invocation |
Comments suppressed due to low confidence (3)
live.go:85
- The log field key
nquadsProcessed
is inconsistent with the variable namenqudsProcessed
(missing the 'a'). Consider renaming the variable tonquadsProcessed
to avoid confusion.
"nquadsProcessed", nqudsProcessed,
config.go:14
- [nitpick] Add a comment explaining the purpose and units of the
cacheSizeMB
field inConfig
for better maintainability (e.g., "// cacheSizeMB sets the in-memory posting list cache size in megabytes").
cacheSizeMB int
load_test/live_test.go:92
- [nitpick] There are no tests validating behavior when
WithCacheSizeMB
is applied (e.g., zero, default, or negative). Consider adding unit tests to verify that the cache size is correctly passed to the engine and that invalid values are rejected.
conf := modusgraph.NewDefaultConfig(t.TempDir()).WithLogger(logger).WithCacheSizeMB(0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the deprecated generics-based API from modusGraph.
It also establishes a mechanism to set the memory cache (ristretto) size when operating in local mode
Checklist