This repository has been archived by the owner on Jun 25, 2022. It is now read-only.
Add support for custom request headers #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@technoboy10 /bump ? |
|
I'm not too keen on the idea of adding a dependency like lodash, when the same result could be accomplished in vanilla JS by doing |
|
Ok no problem, will update. |
|
@technoboy10 updated. |
abepetrillo
force-pushed
the
allow_request_headers
branch
from
b66b666
to
aaa2b96
Compare
|
Spotted I had forgotten to move the require. @technoboy10 launched this on heroku and is working fine. |
|
I'll look over this within the next week. |
|
/bump ? |
|
Sorry for the huge delay! I'll put this on the planning board for v2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #33, I was having trouble talking to APIs who required some headers to be present such as
Accept: application/jsonalong withContent-Type.In order to support this, I've added a configuration file for whitelisting headers we can pass on. To make my life easier I have added lodash. If the extra dependency isn't an issue we can refactor a few areas using some lodash sugar.