fix(controller): Fix add-slots-range algorithm in initCluster (#159)

hyperspike · Jan 10, 2025 · ecdb459 · ecdb459
1 parent f53cfc0
commit ecdb459
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/internal/controller/valkey_controller.go b/internal/controller/valkey_controller.go
@@ -552,6 +552,7 @@ func (r *ValkeyReconciler) initCluster(ctx context.Context, valkey *hyperv1.Valk
 
 	// set cluster slotrange
 	slotRange := 16384 / int(valkey.Spec.Shards)
+	prevEnd := 0
 	for i := 0; i < int(valkey.Spec.Shards); i++ {
 		logger.Info("setting slotrange", "shard", i)
 		r.Recorder.Event(valkey, "Normal", "Setting",
@@ -573,15 +574,19 @@ func (r *ValkeyReconciler) initCluster(ctx context.Context, valkey *hyperv1.Valk
 		if cont {
 			continue
 		}
-		start := slotRange * i
-		end := slotRange*(i+1) - 1
+		start := prevEnd + 1
+		if i == 0 {
+			start = 0
+		}
+		end := start + slotRange
 		if i == int(valkey.Spec.Shards)-1 {
-			end = end + 1
+			end = 16383
 		}
 		if err := clients[podNames[i]].Do(ctx, clients[podNames[i]].B().ClusterAddslotsrange().StartSlotEndSlot().StartSlotEndSlot(int64(start), int64(end)).Build()).Error(); err != nil {
 			logger.Error(err, "failed to set slotrange")
 			return err
 		}
+		prevEnd = end
 	}
 
 	// set cluster meet