chore: templatize prometheus alert rule severity and labels (#149)

.trivyignore

@@ -1,9 +1,12 @@
 # org.apache.helix:helix-core (from upstream opensource shaded dependency. will be taken care during upgrade.)
-CVE-2023-38647 exp:2024-06-30
+CVE-2023-38647 exp:2024-08-31
 
 # org.apache.avro:avro (from upstream opensource shaded dependency. will be taken care during upgrade.)
-CVE-2023-39410 exp:2024-06-30
+CVE-2023-39410 exp:2024-08-31
 
 # org.apache.commons:commons-compress
-CVE-2024-25710 exp:2024-06-30
-CVE-2024-26308 exp:2024-06-30
+CVE-2024-25710 exp:2024-08-31
+CVE-2024-26308 exp:2024-08-31
+
+# io.airlift:aircompressor
+CVE-2024-36114 exp:2024-08-31

helm/templates/controller/prometheusrules.yaml

@@ -11,6 +11,10 @@ metadata:
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
     monitoring: shared
+  {{- if .Values.controller.prometheusrule.annotations }}
+  annotations:
+    {{- toYaml .Values.controller.prometheusrule.annotations | nindent 4 }}
+  {{- end }}
 spec:
   groups:
   - name: pinot
@@ -21,7 +25,10 @@ spec:
         message: '{{`{{ $value }}`}} segments in table {{`{{ $labels.table }}`}} are in Error state'
       expr: sum by(pod, table, tabletype) (pinot_controller_segmentsinerrorstate_value) > 0
       for: 10s
+      for: {{ dig "PinotErrorSegments" "for" "1m" .Values.controller.prometheusrule }}
       labels:
-        severity: critical
-        productgroup: platform-infrastructure
+        severity: {{ dig "PinotErrorSegments" "severity" "critical" .Values.controller.prometheusrule }}
+        {{- with .Values.controller.prometheusrule.additionalRuleLabels }}
+        {{- toYaml . | nindent 12 }}
+        {{- end }}
 {{- end }}

helm/values.yaml

@@ -130,10 +130,14 @@ controller:
 
   servicemonitor:
     enabled: false
-    interval: 15s
+    interval: 30s
     secure: false
     tlsConfig: {}
 
+  prometheusrule:
+    annotations: {}
+    additionalRuleLabels: {}
+
   podDisruptionBudget:
     enabled: false
     maxUnavailable: 1