Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust proposal card redirection and button text #368

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Zied-Dahmani
Copy link
Collaborator

Scope

Ticket

This PR is about making the proposal card clickable, redirecting users to the proposal details page when clicked, in addition to the button. It also updates the button text to Vote instead of Details.

Before After

@Zied-Dahmani Zied-Dahmani requested a review from n13 November 18, 2024 19:20
@Zied-Dahmani Zied-Dahmani self-assigned this Nov 18, 2024
@Zied-Dahmani Zied-Dahmani linked an issue Nov 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n13
Copy link
Collaborator

n13 commented Nov 19, 2024

Prepping build, merging

@n13 n13 merged commit 2984dce into main Nov 19, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Proposal Card
2 participants