feat: Implement Host-Meta Lookup for Social Inbox (#15) #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhileshthite
changed the title
RangerMauve
requested changes
Nov 14, 2023
src/server/apsystem.ts
Outdated
| throw new Error(`Cannot fetch host-meta data from ${hostMetaURL}: http status ${hostMetaResponse.status}`) | ||
| } | ||
|
|
||
| const hostMeta: HostMeta = await hostMetaResponse.json() |
There was a problem hiding this comment.
Host-meta isn't JSON, we need to add an XML parser.
Try this library: https://github.com/NaturalIntelligence/fast-xml-parser/blob/HEAD/docs/v4/2.XMLparseOptions.md
Here's an example XML doc: https://github.com/RangerMauve/staticpub.mauve.moe/blob/default/.well-known/host-meta
akhileshthite
force-pushed
the
host-meta
branch
from
c7117b7 to
b9731be
Compare
RangerMauve
requested changes
Nov 15, 2023
src/server/apsystem.test.ts
Outdated
| @@ -133,6 +133,21 @@ test('getActor uses regular fetch when fromActor is not provided', async t => { | |||
| }, 'getActor should use regular fetch when fromActor is not provided') | |||
| }) | |||
|
|
|||
| // Test for successful Webfinger fetch | |||
| test('mentionToActor successfully fetches data from Webfinger', async t => { | |||
There was a problem hiding this comment.
Mind modifying this test to also stub out the host-meta file?
Try storing the actual webmention at /.well-known/webfinger/acct:[email protected] and the following for the host-meta file:
<?xml version="1.0" encoding="UTF-8"?>
<XRD xmlns="http://docs.oasis-open.org/ns/xri/xrd-1.0">
<Link rel="lrdd" template="https://domain.com/.well-known/webfinge/{uri}"/>
</XRD>
This will help us know whether the parsing works for sure.
RangerMauve
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15