add tests for HTTP APIs and their routes

[akhileshthite]

✘ [fail]: server › api › admins › GET /admins - success
✔ server › api › admins › GET /admins - unauthorized (2.9s)
✘ [fail]: server › api › admins › POST /admins - success
✔ server › api › admins › POST /admins - unauthorized (1.2s)
✘ [fail]: server › api › admins › DELETE /admins - success
✔ server › api › admins › DELETE /admins - unauthorized

  server › api › admins › GET /admins - success

  src/server/api/admins.test.ts:79

   78:                                                                
   79:   t.is(response.statusCode, 200)                               
   80:   t.is(response.body, '[email protected]\[email protected]')

  Difference (- actual, + expected):

  - 403
  + 200

  › file://src/server/api/admins.test.ts:79:5



  server › api › admins › POST /admins - success

  src/server/api/admins.test.ts:107

   106:                                 
   107:   t.is(response.statusCode, 200)
   108: })                              

  Difference (- actual, + expected):

  - 403
  + 200

  › file://src/server/api/admins.test.ts:107:5



  server › api › admins › DELETE /admins - success

  src/server/api/admins.test.ts:138

   137:                                 
   138:   t.is(response.statusCode, 200)
   139: })                              

  Difference (- actual, + expected):

  - 403
  + 200

  › file://src/server/api/admins.test.ts:138:5

  ─

  3 tests failed

[RangerMauve]

Looking great! It'd be good to add a bit more verification of effects beyond checking that the HTTP status code is 200 so we can catch false positives.

[RangerMauve]

Check that either the add method was called or fetch the list to make sure it is populated. Same for the other tests

[akhileshthite]

Resolved for GET /blocklist and GET /allowlist, but getting errors for GET /:actor/blocklist and GET /:actor/allowlist, can you check?



  ✘ [fail]: server › api › blockallowlist › GET /:actor/blocklist - success returns the correct blocklist
  ✘ [fail]: server › api › blockallowlist › GET /:actor/allowlist - success returns the correct allowlist

  server › api › blockallowlist › GET /:actor/blocklist - success

  src/server/api/blockallowlist.test.ts:253

   252:   t.is(response.statusCode, 200, 'returns a status code of 200')                          
   253:   t.deepEqual(response.body.split('\n'), blockedAccounts, 'returns the correct blocklist')
   254: })                                                                                        

  returns the correct blocklist

  Difference (- actual, + expected):

    [
  -   '',
  +   '[email protected]',
  +   '[email protected]',
    ]

  › file://src/server/api/blockallowlist.test.ts:253:5



  server › api › blockallowlist › GET /:actor/allowlist - success

  src/server/api/blockallowlist.test.ts:300

   299:   t.is(response.statusCode, 200, 'returns a status code of 200')                          
   300:   t.deepEqual(response.body.split('\n'), allowedAccounts, 'returns the correct allowlist')
   301: })                                                                                        

  returns the correct allowlist

  Difference (- actual, + expected):

    [
  -   '',
  +   '[email protected]',
  +   '[email protected]',
    ]

  › file://src/server/api/blockallowlist.test.ts:300:5

  ─

  2 tests failed

[RangerMauve]

Akhilesh Thite
: I think the issue with the foractor blocklist in pr #30 is that forActor returns a new object each time so you can't really stub it

[RangerMauve]

What was the behavior that needed this change? .send(object) should already set the status to 200 and the content type to json. https://fastify.dev/docs/latest/Reference/Reply/#objects

[akhileshthite]

return await reply.send({ message: 'Data deleted successfully' }) was giving this error:

✘ [fail]: server › api › creation › DELETE /:actor - success returns success message

  server › api › creation › DELETE /:actor - success

  src/server/api/creation.test.ts:124

   123:   // Examine the response body directly                                                                   
   124:   t.deepEqual(deleteResponse.json(), { message: 'Data deleted successfully' }, 'returns success message');
   125: });                                                                                                       

  returns success message

  Difference (- actual, + expected):

  - '[object Object]'
  + {
  +   message: 'Data deleted successfully',
  + }

  › file://src/server/api/creation.test.ts:124:5

  ─

  1 test failed

[RangerMauve]

Instead of setting up a mock store, try using a regular Store with in-memory storage, then instead of stubbing you could add/remove/list expected data.