Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add full ID in inbox endpoint #49

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: add full ID in inbox endpoint #49

merged 2 commits into from
Mar 14, 2024

Conversation

catdevnull
Copy link
Contributor

fixes #46

@catdevnull catdevnull requested a review from RangerMauve March 7, 2024 20:30
@catdevnull catdevnull force-pushed the issue-46-publicurl-in-urls branch from c67e240 to 6b371ee Compare March 7, 2024 20:31
@catdevnull catdevnull force-pushed the issue-46-publicurl-in-urls branch from 6b371ee to af424e9 Compare March 7, 2024 20:31
RangerMauve
RangerMauve requested changes Mar 8, 2024
View reviewed changes
src/server/api/inbox.ts Show resolved Hide resolved
RangerMauve
RangerMauve approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we can't support stuff like nginx configs with a subpath but that's okay

@RangerMauve RangerMauve merged commit 47d5666 into main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauno fauno fauno left review comments

@RangerMauve RangerMauve RangerMauve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ID for Inbox is incomplete
3 participants
@catdevnull @fauno @RangerMauve