Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxing and unboxing #954

Open
wants to merge 11 commits into
base: next
Choose a base branch
from
Open

Conversation

Juiceman
Copy link
Contributor

Java > 1.4 handles autoboxing

Explicit boxing is not needed in Java > 1.4
Explicit unboxing is not needed in Java > 1.4
src/freenet/client/DefaultMIMETypes.java Outdated Show resolved Hide resolved
src/freenet/client/DefaultMIMETypes.java Show resolved Hide resolved
src/freenet/io/comm/MessageCore.java Show resolved Hide resolved
src/freenet/node/NodeDispatcher.java Outdated Show resolved Hide resolved
src/freenet/node/NodeDispatcher.java Outdated Show resolved Hide resolved
src/freenet/node/NodeDispatcher.java Outdated Show resolved Hide resolved
src/freenet/node/PeerManager.java Outdated Show resolved Hide resolved
src/freenet/node/PeerNode.java Show resolved Hide resolved
test/freenet/support/JVMVersionTest.java Outdated Show resolved Hide resolved
@ArneBab
Copy link
Contributor

ArneBab commented Jun 12, 2024

@Bombe is this ready to be merged now?

@Bombe
Copy link
Contributor

Bombe commented Jun 15, 2024

GitHub’s interface makes it exceedingly difficult to see whether everything was addressed but I do seem to have checked the “verified” checkbox on every single file so I guess this is good now.

@ArneBab
Copy link
Contributor

ArneBab commented Jun 15, 2024

@Bombe thank you for re-checking! I’ll merge this after releasing 1498.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants