-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ant build system to gradle #3
base: master
Are you sure you want to change the base?
Conversation
desyncr
commented
Aug 29, 2020
•
edited
Loading
edited
- Maven project structure
- Android release compilation complains about 'res' reserved keyword
- Remove unused artifacts
- Add verification hashes for gradle witness
Updated target and source compatibility to java 8. Also added gradle witness verification and distribution integrity verification. |
- Android release compilation complains about 'res' reserved keyword - Remove unused artifacts
@ArneBab @JanGerritsen Ready for review. It may seem a lot but there's mostly changes on this commit: abbe6d2 |
Any news on the review? @ArneBab |
I’m sorry that it took me until now. The changes look good to me. Given that Textile-J 2.2 is unmaintained, we might want to keep in bundled, though. We already have two fixes in it — can we get those in with the bundled textile J?
and
|
Sure, I'll apply these changes shortly. |
Thank you! Please also check whether the plugin when built from gradle and inserted to CHK can be loaded and works. |
@desyncr did you apply the changes to upstream? Are they released? Do we need to change the version of the dependency? |
@ArneBab No sorry. I was a bit unsure about re-adding textile and how to do it in Gradle. It's gonna take a bit longer to be ready. I think it's not blocking anything, right? |
desyncr ***@***.***> writes:
@ArneBab No sorry. I was a bit unsure about re-adding textile and how to do it in Gradle. It's gonna take a bit
longer to be ready. I think it's not blocking anything, right?
This is not blocking, no ⇒ all ok :-)
|