Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated files #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

bertm
Copy link
Contributor

@bertm bertm commented Jun 26, 2016

This removes outdated files from the installer's tree. This serves two purposes: it strongly reduces the size of the repository, and prevents accidentally building an installer with old versions of the plugins, seednodes.fref or freenet.jar.

The plugin binaries, seednodes.fref and freenet.jar can safely be removed because as per the specification in the release-wininstaller script, they are to be supplied at build time. The outdated wrapper binaries are stale and no longer references to by the current installer, and can hence be safely removed as well.

@Thynix
Copy link
Contributor

Thynix commented Aug 20, 2016

Hm. They're still in the history, are they not? So they still take up space. I can see the reasoning for not updating them because they'll be overwritten by release-wininstaller, but it does seem useful to be able to build an installer from just what's in the repository. Thoughts?

@nextgens nextgens force-pushed the master branch 11 times, most recently from 175bb9c to 2b96b10 Compare August 1, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants