Add customizable side-by-side mode to HTMLIntegration #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5604 +/- ##
==========================================
+ Coverage 99.42% 99.43% +0.01%
==========================================
Files 239 239
Lines 9421 9427 +6
Branches 2229 2236 +7
==========================================
+ Hits 9367 9374 +7
+ Misses 54 53 -1
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acelaya
force-pushed
the
side-by-side-mode
branch
from
efbdad7
to
8be0d0e
Compare
acelaya
commented
Jul 6, 2023
acelaya
force-pushed
the
side-by-side-mode
branch
3 times, most recently
from
2aabbbe
to
456ecce
Compare
acelaya
commented
Jul 6, 2023
acelaya
force-pushed
the
side-by-side-mode
branch
2 times, most recently
from
3accd6f
to
8e28fb4
Compare
robertknight
reviewed
Jul 6, 2023
acelaya
force-pushed
the
side-by-side-mode
branch
from
8e28fb4
to
e19900e
Compare
I think the answer here can be that we just don't support this flag if other integrations are used. In both cases we are effectively the maintainer of the app that is hosting Hypothesis (or at least, the integration of that app with Hypothesis). |
robertknight
requested changes
Jul 7, 2023
acelaya
force-pushed
the
side-by-side-mode
branch
from
e19900e
to
4b999a0
Compare
acelaya
force-pushed
the
side-by-side-mode
branch
from
4b999a0
to
021834e
Compare
robertknight
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces options in
HTMLIntegration, designed for host applications to have more control overside-by-sidemode.Currently, the only supported option is
mode, which can take these values:auto: It's the client's default value. It will apply some heuristics to determine how the content is affected.manual: expresses the intention of the host app to take control of side-by-side, disabling the logic in the client.This PR does not cover
How these options apply to other integrations (PDF and VitalSource).We won't support this for nowThese will come in follow-up PRs and discussions.