Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sidebar-closing tests in Guest less brittle #5608

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Make sidebar-closing tests in Guest less brittle #5608

merged 1 commit into from
Jul 7, 2023

Commits on Jul 7, 2023

  1. Make sidebar-closing tests in Guest less brittle 

    In tests watching for a `closeSidebar` event being sent to the sidebar, we saw
CI failures [1] due to unrelated messages being sent. Make the checks test for
the specific event we are interested in.

[1] https://github.com/hypothesis/client/actions/runs/5485660737/jobs/9994747006
    @robertknight
    robertknight committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    9619dff View commit details
    Browse the repository at this point in the history