Move TabHeader and TabPanel components to a common location
#5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
shared-tab-components
branch
from
27a45eb
to
7fe68e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5983 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 258 258
Lines 9891 9891
Branches 2361 2361
=======================================
Hits 9836 9836
Misses 55 55 ☔ View full report in Codecov by Sentry. |
acelaya
force-pushed
the
shared-tab-components
branch
from
7fe68e3
to
198ce51
Compare
acelaya
force-pushed
the
shared-tab-components
branch
from
198ce51
to
8d349f4
Compare
I renamed the directory to |
robertknight
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TabHeaderandTabPanelcomponents are currently used in two different places, so this PR extracts them fromShareDialoginto a common location.As part of hypothesis/frontend-shared#1351, it's likely that these components end up in frontend-shared library.