Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fetch_ordered_annotations into a new annotation service #7927

Closed
wants to merge 2 commits into from

Conversation

jon-betts
Copy link
Contributor

@jon-betts jon-betts commented Apr 5, 2023

For:

This is potentially part of a series of PRs to move the storage file into a service for altering annotations.

This is intended to:

  • Make this part of h more like our normal pattern of services
  • Collect similar behavior into the same place

Changes in the PR

This isn't a straight lift and shift. In addition to moving the function the following was changed:

  • We don't accept a general function to mess with the query
  • We only ever used this to eager load things
  • This concentrates the responsibility and testing for eager loading to the service
  • Changed the name to get_annotations_by_id as the ordered bit seems like an implementation detail. I would expect to have to point out of the order came back random, rather than the other way around

@jon-betts jon-betts self-assigned this Apr 5, 2023
@jon-betts jon-betts closed this Apr 20, 2023
@jon-betts jon-betts deleted the storage-fetch-annos-to-svc branch April 20, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant