Move fetch_ordered_annotations
into a new annotation service
#7927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
This is potentially part of a series of PRs to move the storage file into a service for altering annotations.
This is intended to:
h
more like our normal pattern of servicesChanges in the PR
This isn't a straight lift and shift. In addition to moving the function the following was changed:
get_annotations_by_id
as the ordered bit seems like an implementation detail. I would expect to have to point out of the order came back random, rather than the other way around