Replace storage.fetch_annotation with an AnnotationReadService
#7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2023
jon-betts
force-pushed
the
anno-read-svc-fetch
branch
from
6d28234
to
236be2b
Compare
marcospri
approved these changes
Apr 28, 2023
h/notification/reply.py
Outdated
| @@ -62,7 +62,7 @@ def get_notification( | |||
| # Now we know we're dealing with a reply | |||
| reply = annotation | |||
|
|
|||
| parent = storage.fetch_annotation(request.db, parent_id) | |||
| parent = request.find_service(AnnotationReadService).get_annotation_by_id(parent_id) | |||
There was a problem hiding this comment.
Oh why not just annotation.parent? because the whole references thing makes that not trivial 👍
There was a problem hiding this comment.
No, I don't think there's any good reason really. I've swapped this over.
added 3 commits
May 3, 2023 17:24
This involved a rewrite of the tests, because they were quite strange
jon-betts
force-pushed
the
anno-read-svc-fetch
branch
from
236be2b
to
77d90d4
Compare
marcospri
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
Testing notes
In H / Via / ViaHTML / Client:
In one tab:
devdata_user/passIn another private tab:
devdata_admin/passWebsocket
Notification reply
/mail/*in yourhdirectorymail/dir, it should have an*.emlfileNearly anything which has a route on the annotation traversal
There are a bunch in routes which use the traversal, but flag is probably the easiest