-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add teacher details directly to the users table #5303
Merged
+96
−63
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Rename
users
to raw_users
. Also tidy up some comments and indices
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
...ks/report/create_from_scratch/02_entities/01_users/01_raw_users/01_create_view.jinja2.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
DROP MATERIALIZED VIEW IF EXISTS report.raw_users CASCADE; | ||
|
||
-- The building blocks of a user. We won't export this. See | ||
-- `*_entities_decorated/*_users` for the version for external consumers. | ||
CREATE MATERIALIZED VIEW report.raw_users AS ( | ||
SELECT | ||
id, | ||
username, | ||
registered_date::date | ||
FROM h.user AS users | ||
WHERE | ||
users.authority = '{{ region.authority }}' | ||
-- users.authority = 'lms.hypothes.is' | ||
ORDER BY registered_date | ||
) WITH NO DATA; |
8 changes: 8 additions & 0 deletions
8
...ta_tasks/report/create_from_scratch/02_entities/01_users/01_raw_users/02_initial_fill.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
DROP INDEX IF EXISTS report.raw_users_id_idx; | ||
|
||
REFRESH MATERIALIZED VIEW report.raw_users; | ||
|
||
ANALYSE report.raw_users; | ||
|
||
-- A unique index is mandatory for concurrent updates used in the refresh | ||
CREATE UNIQUE INDEX raw_users_id_idx ON report.raw_users (id); |
18 changes: 0 additions & 18 deletions
18
..._tasks/report/create_from_scratch/02_entities/01_users/01_users/01_create_view.jinja2.sql
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
lms/data_tasks/report/create_from_scratch/02_entities/01_users/01_users/02_initial_fill.sql
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left from testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left these in permanently as they are kind of handy when copy pasting things into Metabase to test