Add permission for report to read the event and user tables #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works fine in production, but if you follow the correct instructions locally, it doesn't work. This implies we have the wrong user in prod report, but we should fix this regardless.
jon-betts
commented
May 1, 2023
| GRANT SELECT ON report.groups TO "{{fdw_user}}"; | ||
| GRANT SELECT ON report.group_map TO "{{fdw_user}}"; | ||
| GRANT SELECT ON report.group_bubbled_activity TO "{{fdw_user}}"; | ||
| GRANT SELECT ON report.group_bubbled_counts TO "{{fdw_user}}"; | ||
| GRANT SELECT ON report.group_roles TO "{{fdw_user}}"; | ||
| GRANT SELECT ON report.organization_activity TO "{{fdw_user}}"; | ||
| GRANT SELECT ON report.organization_roles TO "{{fdw_user}}"; | ||
| GRANT SELECT ON report.users TO "{{fdw_user}}"; |
There was a problem hiding this comment.
I've also sorted this alphabetically. The change is the addition of events and users.
marcospri
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For:
This works fine in production, but if you follow the correct instructions locally, it doesn't work. This implies we have the wrong user in prod report, but we should fix this regardless.
Testing notes
To see the issues, checkout
mainhere and then follow the instructions in: hypothesis/report#211You should get permission errors: in this branch you should not.