Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enabling h export_formats feature flag per instance #6002

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Jan 17, 2024

Enable h export_formats feature flag via instance configuration, like we did with import/export.

Testing steps

  1. Disable export_formats in your local h instance: http://localhost:5000/admin/features
  2. Enable export formats in your local LMS instance: http://localhost:8001/admin/instance/8/settings
    image
  3. Open https://hypothesis.instructure.com/courses/125/assignments/4989 and verify the formats dropdown and copy-to-clipboard button are displayed in the export pannel
    image

Considerations

In the assignment linked above, copying to clipboard works, but I have seen others where it doesn't (like https://hypothesis.instructure.com/courses/125/assignments/873).

I'm still trying to figure this out, but it shouldn't block this particular PR.

EDIT: We found the reasons for the issue above: There was missing permissions that had to be set in iframes generated by LMS and via.

Additionally, the wombat.js library used by pywb in viahtml, is overwritting the permissions set by the client. We have opened an issue there: webrecorder/wombat#133

@acelaya acelaya marked this pull request as ready for review January 17, 2024 14:07
@acelaya acelaya changed the title Allow enabling export_formats h FF per instance Allow enabling h export_formats feature flag per instance Jan 17, 2024
Copy link
Member

@marcospri marcospri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setting looks good 👍

You could enable it in one/some of the testing applications instances over https://github.com/hypothesis/devdata if you plan to keep testing this locally.

@acelaya
Copy link
Contributor Author

acelaya commented Jan 18, 2024

You could enable it in one/some of the testing applications instances over https://github.com/hypothesis/devdata if you plan to keep testing this locally.

Thanks! I actually want this mainly to enable it in our LMS instances in QA and prod, plus have a good way to progressively enable in other instances.

In dev envs, we can just enable it globally in h.

@acelaya acelaya merged commit a7b4ad9 into main Jan 18, 2024
8 checks passed
@acelaya acelaya deleted the export-formats-feature branch January 18, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants