Allow enabling h export_formats
feature flag per instance
#6002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable h
export_formats
feature flag via instance configuration, like we did with import/export.Testing steps
export_formats
in your local h instance: http://localhost:5000/admin/featuresConsiderations
In the assignment linked above, copying to clipboard works, but I have seen others where it doesn't (like https://hypothesis.instructure.com/courses/125/assignments/873).
I'm still trying to figure this out, but it shouldn't block this particular PR.EDIT: We found the reasons for the issue above: There was missing permissions that had to be set in iframes generated by LMS and via.
Additionally, the wombat.js library used by pywb in viahtml, is overwritting the permissions set by the client. We have opened an issue there: webrecorder/wombat#133