-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segments filter in assignment view #6689
Conversation
4662139
to
e0e26c1
Compare
bf43327
to
95c279a
Compare
f617c75
to
2d28af2
Compare
We'll merge this PR into #6688, and then merge both together into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good with a few minor comments. One general thing I would be careful about is reusing string literals used as type discriminators to construct UI text, and especially constructing derivatives to handle pluralization etc. Usually a developer would expect that changing such a literal would not break anything as long as they do a simple update (search + replace) for references in the code.
lms/static/scripts/frontend_apps/components/dashboard/AssignmentActivity.tsx
Outdated
Show resolved
Hide resolved
lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx
Outdated
Show resolved
Hide resolved
lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx
Outdated
Show resolved
Hide resolved
lms/static/scripts/frontend_apps/components/dashboard/DashboardActivityFilters.tsx
Outdated
Show resolved
Hide resolved
lms/static/scripts/frontend_apps/components/dashboard/test/AssignmentActivity-test.js
Outdated
Show resolved
Hide resolved
lms/static/scripts/frontend_apps/components/dashboard/test/AssignmentActivity-test.js
Outdated
Show resolved
Hide resolved
lms/static/scripts/frontend_apps/components/dashboard/test/DashboardActivityFilters-test.js
Outdated
Show resolved
Hide resolved
lms/static/scripts/frontend_apps/components/dashboard/test/DashboardActivityFilters-test.js
Outdated
Show resolved
Hide resolved
2d28af2
to
38fd6d6
Compare
Add a fourth filtering dropdown for groups or sections (AKA segments), which is only displayed when the assignment view is loaded.
For now, we only display this filter if the assignment has auto-grading enabled, to reduce potentially affected users in case of an issue, but we'll eventually enable it for any assignment, as it's generally useful.
Its selected values are used to filter the students list and the students metrics.
segments-filter-2024-09-18_10.31.19.mp4
Note
This PR is easier to review ignoring whitespaces
Testing steps