Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer: fix uvBR calculation #7975

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

PaideiaDilemma
Copy link
Contributor

@PaideiaDilemma PaideiaDilemma commented Oct 2, 2024

Describe your PR, what does it fix/add?

Fixes #1462 I think

This looked odd to me, so i added the parenthesis and then the resizing stretches in electron apps disappeared.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

May conflict with #7499 I will check
Does not conflict with #7499

Is it ready for merging, or does it need work?

Needs confirmation that this is (more) correct and someone testing

@fybx
Copy link

fybx commented Oct 2, 2024

looks fine on my end. tested chromium and obsidian with and without --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform-hint=auto

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhhh I don't know if this is right? unsure. Needs testing

@John-Paul-R
Copy link

I can confirm that this definitely appears like a substantially more correct scaling.

Before

2024-10-02_17-49-36_before.c.mp4

After

2024-10-02_18-08-12_after.c.mp4

I am experiencing substantial stutter overall (not just window rescaling) on the locally-built version, but given the nature of the change, I suspect that's more an artifact this being my first install not via package manager, and I've borked something.

@vaxerski
Copy link
Member

vaxerski commented Oct 2, 2024

I realize chromium is better but are other things not broken xd

chromium popups, gtk apps, etc

I think gtk disables shadows now that we sent maximize, so add this patch to revert that one and check native wl gtk aspps

patch.txt

(don't actually use it it's just for testing)

@PaideiaDilemma
Copy link
Contributor Author

Ran it today and also just tested gtk 3 and 4 apps with the patch.
Did not find any issues so far.

@vaxerski
Copy link
Member

vaxerski commented Oct 3, 2024

alright, thanks then

@vaxerski vaxerski merged commit aed529f into hyprwm:main Oct 3, 2024
12 checks passed
@PaideiaDilemma PaideiaDilemma deleted the fix-electron-stretches branch October 10, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect chromium wayland uv while resizing window
4 participants