misc: Add strict typing to attachment manager #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to reject this PR if the new abstraction is too complicated or otherwise not your preference, but it fixes a couple of potential pitfalls and simplifies the external API:
removeByType
beforeadd
because it was possible to have multiple attachments of the same type by accident, but attachments are now stored in a map instead of a vector to guarantee uniqueness.